search

bithost-gmbh / pdfviewhelpers

TYPO3 CMS extension that provides various Fluid ViewHelpers to generate PDF documents.
GNU General Public License v3.0
44 stars 21 forks source link

FEAT Adapt for TYPO3 13 #250

Closed cbaur closed 3 weeks ago

cbaur commented 3 weeks ago

Hi @maechler

As you suggested to my colleague in #249, we gave it a shot and it worked quite well. With only one simple modification, I was able to get the extension up and running on TYPO3 13.4.0. The manual testing I did was to render all the examples form Resources/Public/Examples as well as the news integration for a basic news article. As far as I can see, the automated tests should run after I create this PR via Github Actions, so let's see if that will reveal further issues...

maechler commented 3 weeks ago

@cbaur Thanks, that's already great to hear! It seems that for the tests to run with v13 we'd need to update the typo3/testing-framework to ^8.0@dev. At the same time I would drop support for TYPO3 v11. It will allow us to clean some things up and I think supporting two TYPO3 major versions at the same time is enough for seamless updates.

However even though the tests might run through, I will have to carefully read through the changelog and do some in depth testing. e.g. I stumbled across this change that is also affecting our extension: https://docs.typo3.org/c/typo3/cms-core/main/en-us/Changelog/13.0/Breaking-102600-TSFE-applicationDataRemoved.html

georgringer commented 3 weeks ago

thanks for starting the update! it would be awesome to merge the change in a separate branch so people can try it out and also to give you feedback more easily

maechler commented 3 weeks ago

@cbaur @georgringer I merged this to the branch typo3-v13, dropped support for TYPO3 v11 and raised the testing-framework version. Currently the tests are failing with the following error: 

RuntimeException: No request given. ConfigurationManager has not been initialized properly.

I will need to figure out how to properly initialize the tests with the new version. If you already know the solution, please let me know and feel free to try typo3-v13 already!

https://github.com/bithost-gmbh/pdfviewhelpers/tree/typo3-v13

georgringer commented 3 weeks ago

Take a look at news, one of the last commits, in the functional viewhelpers, solved same error