Error in create PDF string

[objectcruncher]

Hi Markus and Estaban

Markus, do you remember me from Begasoft?

You two have done a cool modern extension to create PDFs, congratulations!

Unfortunately I found an error when creating a PDF String.

In method DocumentViewHelper::render() for outputDestination = "S", the call: $this->getPDF()->Output($outputPath, $this->arguments['outputDestination']); should store the result string and return it from the method.

Would be nice to have fixed for the next release :-)

Have fun Hanspeter

[maechler]

Hi Hanspeter

Hanspeter from the Java team?

Thanks for your error report! Actually that issue should be fixed since release v1.5.1, which I created just yesterday.

The following lines save the output and return it when outputDestination="S": https://github.com/bithost-gmbh/pdfviewhelpers/blob/master/Classes/ViewHelpers/DocumentViewHelper.php#L156 https://github.com/bithost-gmbh/pdfviewhelpers/blob/master/Classes/ViewHelpers/DocumentViewHelper.php#L166

Can you please check whether that solves your issue?

Kind regards Markus

[objectcruncher]

Hi Markus

Yes I was the guy from the Java team.

I tested the creation of a PDF String and it worked! Thank you!

Regards Hanspeter

2018-05-18 7:49 GMT+02:00 Markus Mächler notifications@github.com:

Hi Hanspeter

Hanspeter from the Java team?

Thanks for your error report! Actually that issue should be fixed since release v1.5.1, which I created just yesterday.

The following lines save the output and return it when outputDestination="S": https://github.com/bithost-gmbh/pdfviewhelpers/blob/ master/Classes/ViewHelpers/DocumentViewHelper.php#L156 https://github.com/bithost-gmbh/pdfviewhelpers/blob/ master/Classes/ViewHelpers/DocumentViewHelper.php#L166

Can you please check whether that solves your issue?

Kind regards Markus

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/bithost-gmbh/pdfviewhelpers/issues/50#issuecomment-390101459, or mute the thread https://github.com/notifications/unsubscribe-auth/ADR6ZOqI78Ny5ki_wFqJTk5fhLcOfwG3ks5tzmDdgaJpZM4UDr7M .

--

---

Hanspeter Lutz Sickingerstrasse 5 3014 Bern M: +41 79 401 49 04

[maechler]

Perfect! Thank you Hanspeter for reporting the issue and testing the newest version of pdfviewhelpers.