search

bithound / passport-bitbucket-oauth2

Bitbucket OAuth2 authentication strategy for Passport and Node.js.
MIT License
21 stars 19 forks source link

Atlassian deprecating username #9

Open modestfake opened 5 years ago

modestfake commented 5 years ago

Hi,

Because of GDPR Atlassian changes their APIs. Bitbucket username will be deprecated. nickname should be used instead. More details.

I guess this line should be replaced:

  profile.id = json.uuid;
  profile.displayName = json.display_name;
- profile.username = json.username;
+ profile.nickname = json.nickname;
  profile.profileUrl = json.links.html.href;
modestfake commented 5 years ago

Profile href will be deprecated as well when GDPR changes will be landed.

This will break a lot of projects once GDPR changes will be applied. We need to fix this ASAP. @gtanner do you want me to create a PR?