search

bithyve / bitcoin-keeper

Secure today, plan for tomorrow. BIP 85 hot wallets, buy bitcoin, tor privacy.
https://bitcoinkeeper.app
MIT License
32 stars 11 forks source link

OTB to be available from the Home Screen Manage Keys section. #4654

Open ASN-BitHyve opened 1 month ago

ASN-BitHyve commented 1 month ago

Currently OTB is available only from within the Manage Keys section within a vault.

It should also be available from: Home Screen > Manage Keys > Signing Server/ Inheritance Key Settings > One Time Backup.

Parsh commented 1 month ago

We won't be able to provide One Time Backup option from Home Screen > Manage Keys > Signing Server/ Inheritance Key Settings > One Time Backup, as for both identification of the Signing Server and IKS instance and for constructing their verification(threshold desc) an active vault is required.

Moreover, the Manage signers' screen hosts keys which are added in the app but might not be part of any Vault yet, in that case the One Time Backup option won't really work for IKS at it requires threshold cosigner fingerprint for preliminary verification.

Currently, what we can only do is show a toast and ask the user to access these options from within Manages Keys available under Vault.

Parsh commented 1 month ago

@cakesoft-utkarsh suggestion: Given that only Edit Description is the available option via Home Screen > Manage Keys for Assisted Keys, we might want to get rid of the Edit Description option as well and guide the user to the Settings screen for signer which is accessible from within the Vault.

antuz123 commented 4 weeks ago

General Rule: If an option CAN be on both then it should be on both. Manage Keys and Vault> Manage Keys. ALL KEYS.

We can always get the vault associated with the AK+. The logic of options should be based on if a vault exists or not and not where the Manage Keys> Settings is called from.