search

bithyve / bitcoin-keeper

Secure today, plan for tomorrow. BIP 85 hot wallets, buy bitcoin, tor privacy.
https://bitcoinkeeper.app
MIT License
37 stars 12 forks source link

External Signers: MultiPath support + Fingerprint/PubKey verification #5135

Open Parsh opened 6 days ago

Parsh commented 6 days ago

Task Description Improve the verification(bip32Derv mfp/pubkey) and signing mechanism for External Signers in order to make them compatible for signing a Miniscript-based vault(multipath).

Note: External signers which are on the previous version of the app will require the app to be upgraded to the Miniscript-vault version in order to successfully sign a Miniscript-vault transaction, as they can’t currently parse the chain index(see internallySignVaultPSBT) in a way required to support the multipath approach of Miniscript vaults.

Parsh commented 4 days ago

Addressed by: https://github.com/bithyve/bitcoin-keeper-private/pull/8