search

bithyve / bitcoin-keeper

Secure today, plan for tomorrow. BIP 85 hot wallets, buy bitcoin, tor privacy.
https://bitcoinkeeper.app
MIT License
45 stars 11 forks source link

Signer Addition Modal UI #5182

Closed AreejKhalid21 closed 1 month ago

AreejKhalid21 commented 1 month ago

CTAs needs to be added on Modal IMG_8552 (1)

AreejKhalid21 commented 1 month ago

The Signer addition modal was missing in the design file ,have added both in light an d dark mode now. Also a CTA been added as well.

file: https://www.figma.com/design/m5eMFTKD391AiJAXaEzgxB/Bitcoin-Keeper?node-id=2695-6551&t=iRjHxGnU63kB8i6p-1

Signer Addition Modal2 Signer Addition Modal

Deveshshankar commented 1 month ago

@Raheel1258 can you check if its implemented we can close

Raheel1258 commented 1 month ago

@AreejKhalid21 hasn’t the key addition modal design already changed? It now has different CTAs depending on the key being added. I made this change in the branch @cakesoft-vaibhav is working on for remote key sharing since it’s dependent on it. So, is this ticket still valid?

AreejKhalid21 commented 1 month ago

No this is not valid anymore. These were the old modals and were to be used till the new changes weren't implemented. If the new Signers Addition modals have been implemented as they are in design file then this issue can be closed as signer addition modals have already been updated in design as well. @Raheel1258

Raheel1258 commented 1 month ago

I have still added the CTA just in case the new modal does not go into the release for some reason.

cakesoft-utkarsh commented 1 month ago

IMG_34C15E984EFB-1 Dark mode font color not correct. Check the text SeedSigner** in the screenshot

cakesoft-utkarsh commented 1 month ago

This is invalid not, There is add Description option with associate contact. Closing.. Verifeid on 1.2.17(401)