bithyve / bitcoin-keeper

Secure today, plan for tomorrow. BIP 85 hot wallets, buy bitcoin, tor privacy.
https://bitcoinkeeper.app
MIT License
41 stars 11 forks source link

Device UI improvements #5232

Open ben-kaufman opened 3 weeks ago

ben-kaufman commented 3 weeks ago

Currently the device description is very hard to notice, and is not visible on many parts like the device details screen. The device description should be more visible.

IMG_9517

IMG_C1CC42977DC3-1

AreejKhalid21 commented 1 week ago

Have worked on this issue @ben-kaufman . For the cards components, I have designed them and placed them in design system page both for dark mode and light mode

Figma: https://www.figma.com/design/m5eMFTKD391AiJAXaEzgxB/Bitcoin-Keeper?node-id=3132-4019&t=6LSw0Y7lq1yjdP6a-1

design system: https://www.figma.com/design/m5eMFTKD391AiJAXaEzgxB/Bitcoin-Keeper?node-id=0-1&t=6LSw0Y7lq1yjdP6a-1

S.s: description Cards 2 Cards

I just have one question, Is this screen's new UI design alright? because if so I would have to make changes for all signers screens like this, it is better that I do it now otherwise things would get left out and mistakes will be repeated in app.

design screen: Key Screen

AreejKhalid21 commented 1 week ago

I have made more Improvements/changes in the UI screens now please view @ben-kaufman , Also if this is right then let me know so I can make changes in all keys/signers screens along with their setting screens

Figma link: https://www.figma.com/design/m5eMFTKD391AiJAXaEzgxB/Bitcoin-Keeper?node-id=3132-4019&t=FT0OBNt5Qi9LWrGc-1

s.s description

ben-kaufman commented 1 week ago

Looks great 👍

AreejKhalid21 commented 1 week ago

I have edited all the signers/keys Screens now along with setting screens in the same design style as show above for both Dark and light mode now.

Figma Link: https://www.figma.com/design/m5eMFTKD391AiJAXaEzgxB/Bitcoin-Keeper?node-id=3132-4019&t=FT0OBNt5Qi9LWrGc-1

S.s: Key   Setting Screens _ Light Mode Key   Setting Screens _ Dark Mode

AreejKhalid21 commented 1 week ago

5286 - Tapsigner's settings

ben-kaufman commented 1 week ago

Just to clarify, the design of the device tile should be updated in the same way to show description also in the Wallet creation and manage keys of the wallet.

Also in the sign transaction of a cold wallet, the list of devices will need to show the description. Attaching here screenshots of the relevant screens: IMG_0052

IMG_0053

IMG_0054

AreejKhalid21 commented 3 days ago

Have done the remaining screen UI changes as well. Manage Keys section in wallet/vault, while signing transaction, while making vault or wallet. All screens have been altered @ben-kaufman

https://www.figma.com/design/m5eMFTKD391AiJAXaEzgxB/Bitcoin-Keeper?node-id=3132-4019&t=8I87IZdTy3J0hwE1-1

description