search

bithyve / bitcoin-keeper

Secure today, plan for tomorrow. BIP 85 hot wallets, buy bitcoin, tor privacy.
https://bitcoinkeeper.app
MIT License
45 stars 11 forks source link

Can't sign PSBTs with mobile key #5545

Open mattcrv opened 6 days ago

mattcrv commented 6 days ago

Describe the bug I often get a join.decode input should be string error when trying to scan a PSBT from another Keeper app to sign with my mobile key on Keeper. Sometimes, the scan also gets stuck at 75% without showing any error, and occasionally, pasting shows 100% but doesn’t proceed to the next screen.

To Reproduce

  1. Create a collaborative Vault with one local mobile key and two external keys that are mobile keys generated by other Keeper apps
  2. Generate a PSBT
  3. Scan or paste the PSBT
  4. See error

Expected behavior Transaction signed.

Smartphone (please complete the following information):

ben-kaufman commented 5 days ago

Hi, I believe this has been fixed as part of version 1.2.17, which got delayed for iOS due to some issues with some new Apple regulations.

We have resolved all that and should have a new release which includes a fix for the issue out next week. I will also write here when it's out. Please try with the new release when it's out and let us know if you are still experiencing any issues.

mattcrv commented 4 days ago

Thank you! Unfortunately, I just tested 1.2.18 (413) and the issue persists.

ben-kaufman commented 4 days ago

Hmm, strange, we have tested that flow and couldn't see the issue. Did you update the Keeper app on all devices involved in the transaction? Also maybe try to start over the process by deleting the pending transaction and creating a new PSBT?

mattcrv commented 2 days ago

All devices involved downloaded the app for the first time on the Eastern Time morning of Nov 9. Version 1.2.18 was already released on both iOS and Android by then, so they were all using it.

This happened during a demonstration to 3 people at a conference. Once the bug occurred, I did ask a different person in the group to create the PSBT for the other two to sign, but that still didn’t work. Unfortunately, I’m no longer in touch with them, so I can’t ask them to delete the PSBT and retry.

I don’t plan to try this flow again anytime soon, so feel free to close this issue if it’s indeed already resolved.

ben-kaufman commented 2 days ago

Ok, thanks trying it out and letting us know.

We will do more internal testing and try to see if we can reproduce the issues. I believe the issue was related to one which was fixed in the last release since we had this error message before on certain QR scanning, and it should not be appearing anymore for the newer release, but we will check it more extensively internally to verify.