bithyve / bitcoin-keeper

Secure today, plan for tomorrow. BIP 85 hot wallets, buy bitcoin, tor privacy.
https://bitcoinkeeper.app
MIT License
45 stars 11 forks source link

Fee is calculated incorrectly #5594

Closed ben-kaufman closed 1 week ago

ben-kaufman commented 1 week ago

The fee calculation is using the coinselect library, which uses bytes instead of vbytes for the fee rate, making the fee calculation result in about 2x too much fee.

Also, the send max is overestimating the fee, resulting in too much fee being paid.

cakesoft-swati commented 1 week ago