Closed cakesoft-swati closed 3 years ago
This example is for Keeper.
@antuz123 My understanding is that the wallet name is only supposed to be used as a fallback for when the recipient name doesn't exist. Wouldn't we want the recipient initials to show here?
@CypherPoet - that is ideal but in skip scenarios, we don’t have the initials. What do you suggest the initials to be?
I think if we don't have name information for a contact, we should use the wallet name as the displayedName
. Right now, it looks like we're setting the displayed name to "F&F Request" when there's no actual contact name (see the issue noted here)
That is done when the requester has not Associated a Contact, and the request is not yet accepted. In that case, the wallet name from the receiver is not received. So the "F&F Request" is a temporary placeholder that is to be replaced by the wallet name when received from the receiver.
🤔 That would suggest this is an issue of the placeholder name not being properly removed, because the UI is still finding it set when it also has a wallet name that should be displayed instead.
yup
Having same issue on dev app version 1.3.2(170)
-Recipient name(initials)is different(Showing F1/F2 instead of wallet name initials).9-9a1b0eaa4274.jpg)
-This is for both keeper and trusted contact request.
Doesn't seem to be clipped or cropped. Would be great to know what the residual issue is.
-Display name is different on 'send to contact' and F&F list. In F&F list it is showing csDev and on in send to contact flow it is showing F1 as a contact image.
I haven't been able to replicate this locally -- right now the code is set up to check for a name matching F&F request
to handle the intricacies noted here.
@AliMeer @antuz123 @Parsh Is there another string or set of strings that should be checked to detect F&F requests?
(https://github.com/bithyve/hexa/issues/2056 will also help with these issues)
Tested on live app version 1.3.2(170) <img width="375" alt="795EAD0A-5C35-48D7-88F8-04DBA3BF6321" src="https://user-images.githubusercontent.com/62699947/100318347-e3bf9f80-2fe3-11eb-907e-77bd48f4571a.png"
F1 F2 F3 is showing up on the contact circle, it should be the wallet initials instead.. through out the app for skipped contacts
@cakesoft-swati Can we get this re-checked against the latest build
@cakesoft-swati It will be very useful to know which part of this issue is still outstanding and mention that as a new comment or a new issue.
Tested on Dev app v1.7.0 (283), still showing F1 instead of wallet initials
-Verified this isue on dev app v1.7.5(302)
Send To Contacts Flow: 'last seen active" color indicators on contact avatars.![tempFileForShare_20201118-141522](https://user-images.githubusercontent.com/62699947/99509947-7771ea00-29ac-11eb-8474-62da34ae411f.jpg)
-Recipient name(initials)is different(Showing F1/F2 instead of wallet name initials).9-9a1b0eaa4274.jpg) -Recipient name icon is being cut from the top side. [This is happening in case of Skip contact]