search

bitjson / qr-code

A no-framework, no-dependencies, customizable, animate-able, SVG-based <qr-code> HTML element.
https://qr.bitjson.com/
MIT License
1.17k stars 58 forks source link

Some necessary Types are missing from QrCodeAttributes #6

Open Madame-Aehm opened 6 months ago

Madame-Aehm commented 6 months ago

When using the qr-code element with Typescript in React, I'm getting the error Property 'children' does not exist on type 'QrCodeAttributes'.ts(2322). The child is the img element I've put as an icon.

I also get this error for 'style' and 'className', at least one of which is needed to style it!

If I manually add these properties to the QrCodeAttributes Interface in the Node Modules, it builds without problem, but this only works for development. I've currently just ignored the TS errors to get it to build.

kevinfosterNG commented 1 month ago

+1. I did want to call out that switching from TSX to JSX only for whatever component you're sticking the QR code in does resolve the issue.