Fix coverage

[didierdemoniere]

• What kind of change does this PR introduce? (Bug fix, feature, docs update, ...) fix

• What is the current behavior? (You can also link to an open issue here) nyc ignore .ts files

• What is the new behavior (if this is a feature change)?

• Other information:

[codecov[bot]]

Codecov Report

Merging #205 into master will not change coverage. The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #205   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           9      9           
  Lines         261    261           
  Branches       39     39           
=====================================
  Hits          261    261

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 65f82a9...736b6ba. Read the comment docs.

[codecov[bot]]

Codecov Report

Merging #205 into master will not change coverage. The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #205   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           9      9           
  Lines         261    261           
  Branches       39     39           
=====================================
  Hits          261    261

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 65f82a9...736b6ba. Read the comment docs.

[bitjson]

Hey @didierdemoniere thanks for opening a PR! I can't seem to reproduce the issue – the extension settings should already be automatically set by the extends: @istanbuljs/nyc-config-typescript in package.json:

{
  "cache": false,
  "extension": [
    ".ts",
    ".tsx"
  ],
  "exclude": [
    "**/*.d.ts",
    "coverage/**",
    "packages/*/test/**",
    "test/**",
    "test{,-*}.ts",
    "**/*{.,-}{test,spec}.ts",
    "**/__tests__/**",
    "**/node_modules/**"
  ]
}

If you create a new project, do you still see the issue?

[mrGibi]

I had to manually install @istanbuljs/nyc-config-typescript.

[didierdemoniere]

Hi @bitjson, to reproduce this i run: npx typescript-starter then npm run cov inside the project. is @istanbuljs/nyc-config-typescript installed globally on your setup ?

[bitjson]

@didierdemoniere thanks for responding! (And thank you to @mrGibi too.) You were right – the package was being removed on install by the CLI. I credited you in https://github.com/bitjson/typescript-starter/commit/710bf3e871ee162f3f7bdbfb1438c9b6130562e1, released as v2.4.7.

[didierdemoniere]

thanks @bitjson. This package is a huge time saver, keep up the good work.