search

bitkarrot / laiseebot

Lightning Laisee are little red envelopes on the Lightning Network. Learn more at laisee.org
https://laisee.org
MIT License
7 stars 5 forks source link

Defund action displays wrong link #8

Closed Liongrass closed 2 years ago

Liongrass commented 2 years ago

When selecting 'defund the wallet' the user is sent a QR code and a link. The link however only links to the img.

As an alternative, a hyperlink like the one below could be displayed:

lightning:LNURL1DP68GURN8GHJ7MRWVF5HGUEWDPSHQCTC9E5K7TMHD96XSERJV9MN7ATNWG7NWCFS8Q6NVE3SXQEKGCE5X5UR2WRP

The way the Laisee bot currently works, do we want to give the option to defund the wallet? As it would allow the user to defund the Laisee they already handed out.

bitkarrot commented 2 years ago

Is the QR code not working at all?

the link to the image only was intentional. If you want the LNURL we can also link directly to the webpage, which would be in this following style with button to LNURL

https://lnbits.hapax.io/withdraw/TqEZDGaahmg7v856SLSCEZ

If you feel this is too much of a security risk to expose the link, let me know now and only show the QR code.

Yes i think we should allow option to defund the wallet.

Liongrass commented 2 years ago

Yeah i think that link would be perfect. That's the link to the defund withdrawal LNURL?

bitkarrot commented 2 years ago

Ok yes.

bitkarrot commented 2 years ago

https://github.com/bitkarrot/laiseebot/commit/d24465e44e090d71473055bb0aefc348563568b1