bitkeks / python-netflow-v9-softflowd

PyPI "netflow" package. NetFlow v9 parser, collector and analyzer implemented in Python 3. Developed and tested with softflowd
https://bitkeks.eu/blog/2016/08/collecting-netflow-v9-on-openwrt.html
MIT License
110 stars 56 forks source link

IPFIX: check if handling of signed values is needed #25

Closed bitkeks closed 4 years ago

bitkeks commented 4 years ago

The bytes parser in IPFIX packets uses struct.unpack for each field, based on the corresponding field length. But this implementation ignores signed/unsigned fields, defaulting to unsigned. Since there is at least one signed32 in the fields dict, this check must be implemented. Tests should cover this case as well.