bitlbee / bitlbee-facebook

Facebook protocol plugin for BitlBee
GNU General Public License v2.0
282 stars 43 forks source link

Option to display emojis just as the official clients #178

Open Avamander opened 6 years ago

Avamander commented 6 years ago

It would be really nice if I could disable bitlbee-facebook's de-emoji part, my client can display them nicely.

dgw commented 6 years ago

I don't think I've ever seen bitlbee-facebook remove emoji. If someone in one of my chats sends an emoji, I get it on IRC. Are you sure this isn't a client/font problem?

Avamander commented 6 years ago

There are four ways to send emoji to people on FB messenger: 1) One inserts it directly as emoji e.g: 😊 -> when sent gets enlarged in official clients and ends up as unicode emoji in bitlbee 2) One inserts it directly as emoji among other text -> when sent is displayed as unicode emoji in bitlbee 3) One inserts it as text :) and press space - > when sent gets converted to emoji and enlarged on all official clients ends up as text in bitlbee 4) One inserts it among other text as :) -> when sent it gets converted to emoji on all official clients and gets displayed as text in bitlbee

Now it just seems that bitlbee-facebook doesn't seem to get the emojified text for some reason, could it be requested somehow?

dgw commented 6 years ago

For cases 3 & 4, the clients themselves probably do the transform. bitlbee-facebook would have to convert emoticons to emoji itself, if I'm right about that. Not technically difficult to implement, but the mappings could be tedious to build if they can't be extracted from one of the official apps somehow.

Do keep in mind that I'm basically speculating without looking at the actual data on the wire because it's 3am and I'm half-asleep. There could be a server-side conversion I don't know about, definitely. (But somehow I doubt it.)

As an aside: You might consider changing the title of this issue to reflect what it's actually requesting. What you described doesn't sound like "disabling" a "de-emoji" function, but "enabling" an "emoticon-to-emoji conversion" function instead.

Avamander commented 6 years ago

Not technically difficult to implement, but the mappings could be tedious to build if they can't be extracted from one of the official apps somehow.

A mapping could also solve the problem of seeing a long image url every time someone presses thumbs-up, I can probably write that URL by heart now. Though if bitlbee-facebook starts to convert, then "`", "``````" and LaTeX modes have to be kept in mind (there might be even more), can't emojify math and code. I think this is a good idea but somehow

eyJhb commented 5 years ago

I use this now, for the exact reason that I cannot see emojis in my terminal, and I could not send them. Now If I want to, I can send emojis as I wish, and I can much better understand them, than the normal squares I get in my terminal.

https://github.com/eyJhb/weechat-emoji2ascii

I do not think, this is a request for this extension to Bitlbee, as the client can handle it without a problem..