search

bitlbee / bitlbee-facebook

Facebook protocol plugin for BitlBee
GNU General Public License v2.0
279 stars 49 forks source link

Fix taNewMessage bug (#200) #202

Closed nuxi closed 3 years ago

nuxi commented 3 years ago

The thrift message on the front of this is not a thrift string, but a thrift structure. Until recently it was always an empty structure and so the code was getting away with parsing it as the wrong type.

A few days ago facebook started returning a string in the structure which broke the parser because it was incorrectly treating the first byte as a length.

I'm not sure how flexible this needs to be. All of the funky messages that I get appear to either contain just the stop field (0x00) or a 22-byte string followed by the stop field.

This fixes #200

dequis commented 3 years ago

Thank you so much! I can't test it to reproduce the issue but I'll take your word for it.