search

bitlbee / bitlbee-facebook

Facebook protocol plugin for BitlBee
GNU General Public License v2.0
279 stars 49 forks source link

configure: drop the unnecessary AC_PROG_CC macro check #211

Closed mrc0mmand closed 3 years ago

mrc0mmand commented 3 years ago

This check after commit d8e6c72 breaks build with automake < 1.14 due to a bug, where the AM_PROG_CC_C_O macro overwrites AC_PROG_CC, triggering an error:

$ automake --version | head -n1
automake (GNU automake) 1.13.4
$ ./autogen.sh
autoreconf: Entering directory `.'
autoreconf: configure.ac: not using Gettext
autoreconf: running: aclocal --force -Im4
configure.ac:35: error: AC_PROG_CC cannot be called after AM_PROG_CC_C_O
configure.ac:35: the top level
autom4te: /usr/bin/m4 failed with exit status: 1
aclocal: error: echo failed with exit status: 1
autoreconf: aclocal failed with exit status: 1

If I'm not missing anything this should be safe, since the AC_PROG_CC and AM_PROG_CC_C_O macros do the compiler sanity checks anyway.

dequis commented 3 years ago

Welp.

Do you want a new release with this patch or is it okay if i merge it and wait for other stuff?

mrc0mmand commented 3 years ago

Welp.

Do you want a new release with this patch or is it okay if i merge it and wait for other stuff?

It's definitely okay to wait, the change is pretty simple to do locally when I need it.

dequis commented 3 years ago

Cool. Thank you!