bitluni / DawnOfAV

28 stars 11 forks source link

Not an issue, but a suggestion: Consolidate the RCA stuff as a library (BitluniRCA, maybe?) #2

Open SoftwareGuy opened 6 years ago

SoftwareGuy commented 6 years ago

Hey Bitluni,

This is the same Coburn as the Coburn who got in touch with you via other communication outlets and also backed your Patreon. 😃

Something to consider, could we turn this into a library that can be imported into PlatformIO and/or the Arduino IDE? I use PlatformIO myself and the code worked fine after I did a #include <Arduino.h> in the files that Eclipse IDE didn't know what functions you were calling (mainly the functions that call arduino-esp32 integration functions) as well as fixing some random compile errors (missing includes, etc).

This would not only help us but keep the library in one central location. As it improves, gets refactored and so forth we can just tell people to extract new versions of the library to their library folder, and we all win, rather than using an outdated version of the headers because we based it off a old example while the newer example offers much improved speed, etc.

I can always consolidate it for you and put it on a repo on my github, then you can bring it across at your leisure.

BTW: Tested the example code of Venus/Mars (?) and the SpaceX car - 34 FPS on my Adafruit ESP32. I did a video about it here, if you want to see my result - https://www.youtube.com/watch?v=bc_ZSRmBslc (apologies in advance if i butchered up your name while i recorded that video).