bitly / bitly-api-python

python library to the bitly api
http://github.com/bitly/bitly-api-python
Other
245 stars 92 forks source link

Duplicated method name bundle_collaborator_remove in Connection #15

Closed ianozsvald closed 11 years ago

ianozsvald commented 11 years ago

The pep8 module discovered this duplicated method, I'm not sure which of the two endpoints are the correct choice:

 class Connection(object):
    def bundle_collaborator_remove(self, bundle_link, collaborator):
        """remove a collaborator from a bundle"""
        params = dict(bundle_link=bundle_link)
        params["collaborator"] = collaborator
        data = self._call_oauth2_metrics("v3/bundle/collaborator_remove", params)
        return data
    def bundle_collaborator_remove(self, bundle_link, collaborator):
        """remove a pending collaborator from a bundle"""
        params = dict(bundle_link=bundle_link)
        params["collaborator"] = collaborator
        data = self._call_oauth2_metrics("v3/bundle/pending_collaborator_remove", params)
        return data
jsocol commented 11 years ago

Fixed by #16