bitly / bitly-api-python

python library to the bitly api
http://github.com/bitly/bitly-api-python
Other
244 stars 92 forks source link

Connection._call timeout argument is unused #48

Open pramttl opened 6 years ago

pramttl commented 6 years ago

The Connection._call timeout argument defaults to 5000 but seems to be unused. https://github.com/bitly/bitly-api-python/blob/master/bitly_api/bitly_api.py#L774

goodspark commented 6 years ago

Looks like it should be passed to https://github.com/bitly/bitly-api-python/blob/master/bitly_api/bitly_api.py#L802 https://docs.python.org/2/library/urllib2.html#urllib2.OpenerDirector.open