bitly / go-notify

a Go package to observe notable events in a decoupled fashion
238 stars 26 forks source link

Add `PostTimeout` function #1

Closed rafrombrc closed 11 years ago

rafrombrc commented 11 years ago

This patch makes 4 changes:

The PostTimeout and StopAll functions are both particularly useful from within test code, when you might be exercising code that sets up event listeners that are otherwise beyond control of the tests themselves.

mreiferson commented 11 years ago

thanks @rafrombrc I completely missed this pull request, sorry for the delay...

mreiferson commented 11 years ago

overall changes look good other than those few nitpicks

rafrombrc commented 11 years ago

Yup, good spots. Made the requested changes.

mreiferson commented 11 years ago

cool, thanks. do you mind squashing this down to one commit?

mreiferson commented 11 years ago

errr, maybe 3:

  1. for the error change
  2. for StopAll
  3. for PostTimeout

?

rafrombrc commented 11 years ago

Commits squashed. First time I've used "git rebase -i"... surprisingly easy!