search

bitly / oauth2_proxy

A reverse proxy that provides authentication with Google, Github or other provider
MIT License
5.1k stars 1.21k forks source link

Fix GitHub teams for large orgs #613

Open skwashd opened 6 years ago

skwashd commented 6 years ago

Some large organisations have more than 100 teams. The current implementation only checks the first 100 teams returned by the API. This checks all teams the user is a member of.

Added support for GitHub's new nested team feature which means inheritence works as designed. Again useful for large orgs.

Updated the limit from 200 to the documented limit of 100.

skwashd commented 6 years ago

Travis failing due to an error with dep. https://travis-ci.org/bitly/oauth2_proxy/jobs/387385489#L598 The last 3 master builds have failed due to issues with fsnotify.v1. It looks like #610 fixes this problem.

alexlupascu commented 6 years ago

I've tested the code from this PR on large Github org, all works good.