search

bitly / oauth2_proxy

A reverse proxy that provides authentication with Google, Github or other provider
MIT License
5.1k stars 1.21k forks source link

Please review options handling #638

Open mgoritzk opened 5 years ago

mgoritzk commented 5 years ago

This tool is great but a start with this tool would be much, much more easier, if the options handling would work basically the same.

Sometimes options works with only one "-" character, sometimes it is necessary to use two "-" characters. Sometimes the equal character is needed, sometimes not. Passing an option via command line is sometimes different than in the config file (e.g. upstream vs upstreams).

I am sure that unifying options handling and names will increase attention for this product enormously.

ploxiln commented 5 years ago

All command-line flags accept both one - and two --. All command-line flags work with an = or with a space before the value. This is the behavior of the go standard-library "flag" package. Any inconsistency is just in the documented examples.

Pluralization differences are intentional and meaningful, but there are a couple unintentional inconsistencies. See https://github.com/bitly/oauth2_proxy/pull/363