search

bitly / statsdaemon

an implementation of Etsy's statsd in Go
The Unlicense
570 stars 131 forks source link

Old buckets are never purged #14

Closed JensRantil closed 9 years ago

JensRantil commented 11 years ago

I'm reading the code right now and notice that older buckets are never purged. Untouched buckets should probably have some kind of TTL. This is especially important for autogenerated counters. Creating this issue to make you aware of this. Please close if it's a non-issue.

JensRantil commented 11 years ago

For counters, this is probably a simple fix. I believe, a delete(counters, s) call could be added here.

mreiferson commented 10 years ago

closed by #16

JensRantil commented 10 years ago

This issue is not fully fixed. Only for counters.

mreiferson commented 10 years ago

oops

JamesCohen-awin commented 9 years ago

It might be possible to re-use the approach to purging counters in #41 to clean up gauges and other metrics too.

Happy to look into this if everyone's happy with #41 and it gets merged in to master.

JamesCohen-awin commented 9 years ago

I submitted #51 to purge timers. Gauges now need to be persisted to allow for relative gauge operations so I think this is done.

mreiferson commented 9 years ago

resolved in #51