Simplified tests

[JamesCohen-awin]

I tidied up some of the tests:

• The tests for mean and percentiles don't rely on the (already tested) parseMessage() function
• Instead of using time.Now().Unix() a constant is used instead to remove variables from the test and to make simpler (string == string) assertions
• Modified some test function names to reflect the names of the functions they test

[JamesCohen-awin]

also of note for whoever reviews this...

I removed the test from statsdaemon_test.go#L286 as the test string shouldn't appear in the output and wasn't being - even though the test was passing(!)

[mreiferson]

curious what go test -cover reports before/after this change? would you mind pasting?

[JamesCohen-awin]

coverage reduces a tiny bit

$ diff /tmp/cover-master.txt /tmp/cover-tidyup.txt 
13c13
< github.com/bitly/statsdaemon/statsdaemon.go:226:  processTimers   100.0%
---
> github.com/bitly/statsdaemon/statsdaemon.go:226:  processTimers   97.4%
17c17
< total:                            (statements)    56.2%
---
> total:                            (statements)    55.6%

It's the "continue" here that is no longer covered:

func processTimers(buffer *bytes.Buffer, now int64, pctls Percentiles) int64 {
        var num int64
        for u, t := range timers {
                if len(t) == 0 {
                        continue
                }

[mreiferson]

k, thanks again :grin: