search

bitmaelum / bitmaelum-suite

BitMaelum software suite
https://bitmaelum.com
MIT License
61 stars 5 forks source link

Cleanup code smells from sonarcloud #94

Open jaytaph opened 3 years ago

jaytaph commented 3 years ago

Take some time to do a cleanup of the code smells as found in sonarcloud:

https://sonarcloud.io/project/issues?id=bitmaelum_bitmaelum-suite&resolved=false

GreenStage commented 3 years ago

Hi, this project looks interesting, I'm eager to contribute.

This issue presents itself as a nice starting point into your codebase, mind if take it?

jaytaph commented 3 years ago

welcome! We're always happy to have new people contribute. You're more than welcome to pick up issues. The code might be a little hard to grasp maybe because there is a lot going on, but most of the sonarcloud issues are doable enough.

GreenStage commented 3 years ago

https://github.com/bitmaelum/bitmaelum-suite/pull/171

jaytaph commented 3 years ago

image

Pretty nice work done! We got rid of half the code smell issues

I leave this issue open for now, so we can tackle the rest later