search

bitmagnet-io / bitmagnet

A self-hosted BitTorrent indexer, DHT crawler, content classifier and torrent search engine with web UI, GraphQL API and Servarr stack integration.
https://bitmagnet.io/
MIT License
2.01k stars 76 forks source link

Make datasources for Grafana dashboard configurable #188

Closed Ornias1993 closed 2 months ago

Ornias1993 commented 3 months ago

Does what is states on the tin. Adds a little selectionbox up-top to select the datasource instead of hardcoding one.

mgdigital commented 3 months ago

Thanks, looks good and I'll test it when I get a chance. Just a couple of small things:

Ornias1993 commented 3 months ago

Thanks, looks good and I'll test it when I get a chance. Just a couple of small things:

  • could you revert the casing change to bitmagnet?
  • should the next version be 2 rather than 3?
  • what is that "id": 79 referring to?
DyonR commented 3 months ago
  • Shouldn't names be cased like names?

It just a style choice to have bitmagnet all lowercase. For example, the brand adidas is also stylized with all lowercase.
You would also write BitTorrent and not Bittorrent, and you also wouldn't write QBittorrent, but qBittorrent. It are all style choices of the authors.
Edit:
One more example (to give a Dutch example); bol, formerly known as bol.com, is also a brand which uses only lowercase letters. (except in the history section and if sentences start with bol)
You can see bol only written in lowercase: https://pers.bol.com/nl/het-verhaal/

Ornias1993 commented 3 months ago
  • Shouldn't names be cased like names?

It just a style choice to have bitmagnet all lowercase. For example, the brand adidas is also stylized with all lowercase. You would also write BitTorrent and not Bittorrent, and you also wouldn't write QBittorrent, but qBittorrent. It are all style choices of the authors. Edit: One more example (to give a Dutch example); bol, formerly known as bol.com, is also a brand which uses only lowercase letters. (except in the history section and if sentences start with bol) You can see bol only written in lowercase: https://pers.bol.com/nl/het-verhaal/

You don't need to explain stylisation to me. It comes over as incredibly arrogant and belittling. I get stylisation, It's done frequently, Even I do it. Afaik there is simply not a style guide for Bitmagnet. Thats why I even asked.

So there was no reason to all-of-a-sudden start, what is basically, mansplaining.

But for references, writhing names without a capital is still incorrect. Even if a "style guide" proclaims otherwise. But well, that's how it is. Its up to the maintainer to decide on this, I'm 100% okey with both and don't actually give a duck about it.

I just corrected it and asked because there is no style guide >.<