bitmaker-software / tomee-cli

The fast way to configure Apache TomEE
Apache License 2.0
6 stars 0 forks source link

Support for easy datasource configuration by vendor. #26

Open danielsoro opened 9 years ago

danielsoro commented 9 years ago

Support to configure database by vendor, like:

(add-new-datasource-resource :mysql) (add-new-datasource-resource :oracle) (add-new-datasource-resource :sql) (add-new-datasource-resource :...)

This case the TomEE-CLI automatically download the drive and put in TOMEE_HOME/lib and configure the resource.

The user doesn't need to pass jdbc-driver and jdbc-url, the TomEE-CLI should need to receive only the port (has a default value case the user doesn't pass), database-name, username and password.

htmfilho commented 9 years ago

I'd suggest to remove either "add" or "new". I think both is redundant.

danielsoro commented 9 years ago

Make sense. I'll remove new. (add-datasource-resource [...])

htmfilho commented 9 years ago

Since it will download the driver, I will move the function (download-file) from installation.clj to utils.clj.

danielsoro commented 9 years ago

Thank you @htmfilho. I'll need this function. :D