bitmark-inc / autonomy-apps

1 stars 1 forks source link

There is 1 duplicated Feral File connection display when user connect to FF by Wallet Connect and Autonomy Connect #1968

Open longbmk opened 1 year ago

longbmk commented 1 year ago

image

hvthhien commented 1 year ago

Technically, that's 2 different connections, so it is expected to show 2 rows. If we want to make user less confuse, we should have a new design (maybe divide into 2 sections for Au connect and Wc connect)

longbmk commented 1 year ago

@Anais-bitmark Please kindly help us design for it. Thank you

longbmk commented 1 year ago

@bm-kiennguyen Can we return the text "Feral File - Wallet Connect" and "Feral File - Autonomy connect" for 2 type of the connection? CC @hvthhien @Anais-bitmark

Anais-bitmark commented 1 year ago

@longbmk

Figma

@hvthhien for Tezos, connections can happen through Beacon Standard or Autonomy Connect right?

UI [0.1 unit]

Capture d’écran 2023-01-06 à 12 27 19
longbmk commented 1 year ago

@Anais-bitmark Thank you for your design. For the design for Tezos, please use "Feral File - Beacon Connect" or "Feral File - Beacon Wallet". CC @hvthhien

anhnguyenbitmark commented 1 year ago

@Anais-bitmark I don't think we should provide the suffix Wallet Connect and Autonomy Connect. They are protocol names, which should be confusing when the users see them.

Instead of showing this, can we prevent users from connecting to the Autonomy app (from Feral File) with WalletConnect? Since Feral File has Autonomy Connect and Other wallets at the same level, I would think we should not let the user use Wallet Connect in the "Other wallets" option. Unfortunately, we couldn't remove the Autonomy option in the Other wallets on the Feral File website.

Anais-bitmark commented 1 year ago

@anhnguyenbitmark it would be ideal but how so if we can't remove the Autonomy from the list of "Other Wallets"? It will never work? or you didn't manage yet to remove it?

Anais-bitmark commented 1 year ago

Figma

Capture d’écran 2023-02-22 à 15 57 53
anhnguyenbitmark commented 1 year ago

@Anais-bitmark It doesn't work. We cannot remove the wallet in the Beacon dialog.

ppupha commented 1 year ago

@bencebitmark please help to finalise the UI.

bencebitmark commented 1 year ago

@ppupha not sure if i understand this story correctly, but i think the issue doesn't happen anymore: • in Autonony, there's only one Feral File connect listed for both the Tezos and Ethereum addresses • Wallet Connect or Beacon modal doesn't list Autonomy twice

ppupha commented 1 year ago

@bencebitmark I check and it still happends. It's show 2 Feral File connections when we connect to FF using Autonomy Connect and Wallet Connect. 1696493779031

bencebitmark commented 1 year ago

oh okay, i managed to replicate it. just to clarify i understand correctly when this happens:

  1. i connect to Feral File using Wallet Connect.
  2. i then log out, or open a different browser. i use Autonomy Connect at Feral File.
  3. two connections show up for Feral File on the same addresses.

is this correct?

ppupha commented 1 year ago

Yes

bencebitmark commented 1 year ago

is it possible to combine the WalletConnect and Autonomy Connect items to just one? so when you disconnect, you disconnect both.

but tbf, i'm not sure if we're looking at this on the right level. this issue is unique to Feral File, and can't happen on any other dapp? is there value in us showing both WalletConnect and Autonomy Connect on Feral File?

ppupha commented 1 year ago

Technically, that's 2 different connections, so it is expected to show 2 rows. If we want to make user less confuse, we should have a new design (maybe divide into 2 sections for Au connect and Wc connect)

@bencebitmark

bencebitmark commented 1 year ago

yes, it's two different connections, but i wouldn't change the entire screen for an issue that only occurs for a single dapp (Feral File). dividing it into Autonomy and Wallet Connect isn't the right approach here imo.

i still don't think we're addressing it at the right level: i'd like to address this at the root cause level instead of inventing a UI pattern that's not familiar to users.

i'd place this ticket in the backlog for now, as we're working out a solution that'd hide all of this info even more.

ppupha commented 1 year ago

@moskovich do you agree with this?

moskovich commented 1 year ago

I think it should only show one connection. Overwrite the last one.