search

bitmovin / bitmovin-javascript

DEPRECATED: JavaScript client for the Bitmovin API, see https://github.com/bitmovin/bitmovin-api-sdk-javascript
MIT License
67 stars 23 forks source link

Add create methods to use POST endpoints to create analytics/player licenses #101

Closed Svarozic closed 5 years ago

Svarozic commented 5 years ago

https://github.com/bitmovin/dashboard/issues/642

codecov[bot] commented 5 years ago

Codecov Report

Merging #101 into develop will decrease coverage by 0.23%. The diff coverage is 60%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #101      +/-   ##
===========================================
- Coverage    96.01%   95.78%   -0.24%     
===========================================
  Files           70       70              
  Lines         1606     1612       +6     
  Branches        55       55              
===========================================
+ Hits          1542     1544       +2     
- Misses          64       68       +4
Impacted Files Coverage Δ
bitmovin/analytics/licenses.ts 87.5% <60%> (-7.74%) :arrow_down:
bitmovin/player/licenses.ts 90% <60%> (-10%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 532bbe3...ec1e5d6. Read the comment docs.

codecov[bot] commented 5 years ago

Codecov Report

Merging #101 into develop will increase coverage by 0.01%. The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #101      +/-   ##
===========================================
+ Coverage    96.01%   96.02%   +0.01%     
===========================================
  Files           70       70              
  Lines         1606     1612       +6     
  Branches        55       55              
===========================================
+ Hits          1542     1548       +6     
  Misses          64       64
Impacted Files Coverage Δ
bitmovin/analytics/licenses.ts 95.83% <100%> (+0.59%) :arrow_up:
bitmovin/player/licenses.ts 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 532bbe3...54a985b. Read the comment docs.

Svarozic commented 5 years ago

Is it not possible to add the return type here?

Could you make it like code comment, so I would be able to see place where ?