bitmovin / bitmovin-javascript

DEPRECATED: JavaScript client for the Bitmovin API, see https://github.com/bitmovin/bitmovin-api-sdk-javascript
MIT License
67 stars 23 forks source link

Feature/add object detection endpoints #108

Closed cagdotin closed 5 years ago

cagdotin commented 5 years ago
codecov[bot] commented 5 years ago

Codecov Report

Merging #108 into develop will increase coverage by <.01%. The diff coverage is 96.66%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #108      +/-   ##
===========================================
+ Coverage    96.12%   96.13%   +<.01%     
===========================================
  Files           72       74       +2     
  Lines         1650     1680      +30     
  Branches        55       55              
===========================================
+ Hits          1586     1615      +29     
- Misses          64       65       +1
Impacted Files Coverage Δ
...tmovin/encoding/encodings/machineLearning/index.ts 100% <100%> (ø)
bitmovin/encoding/encodings/index.ts 100% <100%> (ø) :arrow_up:
...oding/encodings/machineLearning/objectDetection.ts 95.65% <95.65%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bc67ff0...6634a25. Read the comment docs.

codecov[bot] commented 5 years ago

Codecov Report

Merging #108 into develop will increase coverage by <.01%. The diff coverage is 96.66%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #108      +/-   ##
===========================================
+ Coverage    96.12%   96.13%   +<.01%     
===========================================
  Files           72       74       +2     
  Lines         1650     1680      +30     
  Branches        55       55              
===========================================
+ Hits          1586     1615      +29     
- Misses          64       65       +1
Impacted Files Coverage Δ
...tmovin/encoding/encodings/machineLearning/index.ts 100% <100%> (ø)
bitmovin/encoding/encodings/index.ts 100% <100%> (ø) :arrow_up:
...oding/encodings/machineLearning/objectDetection.ts 95.65% <95.65%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bc67ff0...6634a25. Read the comment docs.

cagdotin commented 5 years ago

@lukaskroepfl I have discussed with @fabiandev about the comments that he has made. Currently it is OK for him if we merge like that since same implementation was made in multiple places like Streams ...etc. if you also think that it is g2g we can merge?