bitmovin / bitmovin-javascript

DEPRECATED: JavaScript client for the Bitmovin API, see https://github.com/bitmovin/bitmovin-api-sdk-javascript
MIT License
67 stars 23 forks source link

Add burning in SRT subtitle file support #98

Closed koraygulcu closed 5 years ago

koraygulcu commented 5 years ago

Encoder supports burning in SRT sidecar files since 2.4.0. This makes use of the available API. It contains unit test for the new endpoint and a full example to demonstrate the feature. Validated with a sample video and SRT file.

codecov[bot] commented 5 years ago

Codecov Report

Merging #98 into develop will decrease coverage by 0.01%. The diff coverage is 95.23%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #98      +/-   ##
===========================================
- Coverage    96.02%   96.01%   -0.02%     
===========================================
  Files           69       70       +1     
  Lines         1585     1606      +21     
  Branches        55       55              
===========================================
+ Hits          1522     1542      +20     
- Misses          63       64       +1
Impacted Files Coverage Δ
bitmovin/encoding/encodings/streams/index.ts 100% <100%> (ø) :arrow_up:
...ovin/encoding/encodings/streams/burnInSubtitles.ts 95% <95%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9da344b...6a752d3. Read the comment docs.

codecov[bot] commented 5 years ago

Codecov Report

Merging #98 into develop will decrease coverage by 0.01%. The diff coverage is 95.23%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #98      +/-   ##
===========================================
- Coverage    96.02%   96.01%   -0.02%     
===========================================
  Files           69       70       +1     
  Lines         1585     1606      +21     
  Branches        55       55              
===========================================
+ Hits          1522     1542      +20     
- Misses          63       64       +1
Impacted Files Coverage Δ
bitmovin/encoding/encodings/streams/index.ts 100% <100%> (ø) :arrow_up:
...ovin/encoding/encodings/streams/burnInSubtitles.ts 95% <95%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9da344b...6a752d3. Read the comment docs.