search

bitmovin / bitmovin-player-android-analytics-conviva

Integration of the Bitmovin Android Player SDK with the Conviva Analytics
MIT License
1 stars 4 forks source link

Feature/fix tests for conviva upgrade #40

Closed sinewave440hz closed 2 years ago

sinewave440hz commented 2 years ago

Almost all tests are running now. The exception is the three metadata tests, which I can't quite solve at this stage...

luckygoyal-bitmovin commented 2 years ago

Hi @sinewave440hz , can you please raise this PR against development branch instead of main?

sinewave440hz commented 2 years ago

Ah this happens by default when you do a PR unfortunately. Which explains last time as well (I was working from develop prior to that).

luckygoyal-bitmovin commented 2 years ago

Ah this happens by default when you do a PR unfortunately. Which explains last time as well (I was working from develop prior to that).

I guess that is because main branch is the default branch. But thanks for changing the PR to develop.

luckygoyal-bitmovin commented 2 years ago

@sinewave440hz , except for Metadata test failure, changes look ok in general. Approving the PR for the fixed test cases.