bitmovin / bitmovin-player-android-analytics-conviva

Integration of the Bitmovin Android Player SDK with the Conviva Analytics

MIT License

1 stars 4 forks source link

Wire up SSAI #73

Closed strangesource closed 4 months ago

strangesource commented 4 months ago

Problem

The SSAI API introduced in #72 is not yet used.

Changes

Add SSAI API to ConvivaAnalyticsIntegration
Expose SSAI namespace on ConvivaAnalyticsIntegration
Reset SSAI state on internal session end
Report stream error as ad error in case of active SSAI ad
Add first instrumentation test

Limitations

On SSAI ad start we currently don't report initial values for resolution, bitrate and framerate. This will be done in a follow up PR.

Related Changes

69

72

strangesource commented 4 months ago

I can't comment on the SSAI API integration code as it was already merged before but I think we should consider taking the tags produced by contentMetadataBuilder.build() when passing adInfo.

On the iOS integration I had to do that to fix errors showing up due to missing tags, like viewer ID and player name. These are documented as "Autocollected" but in practice that didn't happen on iOS.

The other option could be that on the iOS integration we only "patch" the "Autocollected" values.

What do you think?

I am a bit reluctant to just pass everything, as metadata might be explicitly set for the main content and not relevant for ads. The "patch auto collected" seems like a safe approach here.

Edit: As discussed, on Android we don't seem to have these issues.

rolandkakonyi commented 4 months ago

I can't comment on the SSAI API integration code as it was already merged before but I think we should consider taking the tags produced by contentMetadataBuilder.build() when passing adInfo. On the iOS integration I had to do that to fix errors showing up due to missing tags, like viewer ID and player name. These are documented as "Autocollected" but in practice that didn't happen on iOS. The other option could be that on the iOS integration we only "patch" the "Autocollected" values. What do you think?

I am a bit reluctant to just pass everything, as metadata might be explicitly set for the main content and not relevant for ads. The "patch auto collected" seems like a safe approach here.

Edit: As discussed, on Android we don't seem to have these issues.

Agree, after having a sleep on it came the "patch" idea up. I will continue with that approach.