search

bitmovin / bitmovin-player-ui

The Bitmovin Adaptive Streaming Player UI
MIT License
126 stars 87 forks source link

Enable playback speed selector by default #184

Closed bitmovin-kenny closed 5 years ago

bitmovin-kenny commented 6 years ago

In https://github.com/bitmovin/bitmovin-player-ui/pull/125 we introduced a flag to hide the PlaybackSpeedSelectionBox, we also accidentally disabled the Selection by default.

The default should be to show the PlaybackSpeed Selection Box.

protyposis commented 6 years ago

Didn't we do that on purpose? Actually I like this change and think this is a rather unimportant feature which makes sense to be opt-in.

dweinber commented 6 years ago

It was not intended to change the default from my point of view.

protyposis commented 6 years ago

It's even in the changelog, how could that happen "accidentally"?

protyposis commented 5 years ago

Fixed in https://github.com/bitmovin/bitmovin-player-ui/pull/198 & https://github.com/bitmovin/bitmovin-player-ui/pull/199