listbox does not implement listbox a11y pattern

bitmovin / bitmovin-player-ui

The Bitmovin Adaptive Streaming Player UI

MIT License

126 stars 87 forks source link

listbox does not implement listbox a11y pattern #607

Closed oberhamsi closed 4 months ago

oberhamsi commented 8 months ago

the listbox fits the listbox pattern

but does not properly implement it. we were able to subclass and monkey-patch some of the problems:

listbox must have role=listbox
children of listbox muste have role=option and a unique id
keyboard controls for virtual focus managment (arrow keys) and aria-activedescendant as described in the pattern

what we could not easily change:

buttons used as role=option should have aria-selected and not aria-pressed states

jamesdavidholding commented 4 months ago

Hi Oberhamsi

We will be closing the ‘Issues’ tab for this Repo this week. If this issue still affects you, please can I ask that you re-raise it through the Bitmovin Support Dashboard, where we will happily pick it up.

This change improves our response times to you, as the support team is not monitoring GitHub repro.

Many thanks,

James - Support