bitmovin / bitmovin-player-ui

The Bitmovin Adaptive Streaming Player UI
MIT License
126 stars 87 forks source link

Rewrite `hasLocalStorage` check to not produce `localStorage`-entries #612

Closed Andr3wid closed 7 months ago

Andr3wid commented 7 months ago

Description

Existence of the localStorage API was probed so far by creating (and immediately deleting) a localStorage-entry. This is undesirable behaviour in case a page wishes to not have the localStorage-API utilized in any way.

This PR introduces the following changes:

Anyways, a localStorage item would still be set if certain feature of the player-UI are used. PR is a followup to introduce disabling of localStorage.

Checklist (for PR submitter and reviewers)