bitmovin / bitmovin-player-ui

The Bitmovin Adaptive Streaming Player UI
MIT License
126 stars 87 forks source link

`ControlBar` not auto-hiding on some touch screen devices #620

Closed zigavehovec closed 6 months ago

zigavehovec commented 6 months ago

Description

Jira ticket: https://bitmovin.atlassian.net/browse/PA-2232

Based on this comment, the UIConfig.disableAutoHideWhenHovered flag is meant to be used only on non touch screen devices. The code that applied the config checked for BrowserUtils.isMobile, which returns false on some Android tablets. This caused the ControlBar to not hide on some Android tablets when disableAutoHideWhenHovered is set to true.

To fix the issue the BrowserUtils.isMobile check has been replaced with BrowserUtils.isTouchSupported which also covers tablets and generally better fits the use-case.

Checklist (for PR submitter and reviewers)