search

bitmovin / bitmovin-player-ui

The Bitmovin Adaptive Streaming Player UI
MIT License
126 stars 87 forks source link

Improve demopage #629

Closed dweinber closed 3 months ago

dweinber commented 3 months ago

Description

Two small but hopefully useful improvements of the playground demo page:

  1. A checkbox to enable/disable ads on the fly in the demo page UI as shown below. Previously, this needed to be done somewhere in the demo page's code. image
  2. Store the basic configuration of the playground (video source, UI, ads enabled) in localStorage of the browser and load on page load

Checklist (for PR submitter and reviewers)

dweinber commented 3 months ago

Thanks @felix-hoc! Classic case of testing it, then refactoring the code and introduce a bug by that 😄 Should be fixed now in https://github.com/bitmovin/bitmovin-player-ui/pull/629/commits/28cfa59f09cca218a0d91b152f2c2a121820d9a6