search

bitmovin / bitmovin-player-ui

The Bitmovin Adaptive Streaming Player UI
MIT License
126 stars 87 forks source link

Add Dutch (nl) localisation #645

Closed lextas closed 1 month ago

lextas commented 2 months ago

Description

Added localisation for Dutch (nl)

CLAassistant commented 2 months ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

:white_check_mark: lextas
:x: wasp898
You have signed the CLA already but the status is still pending? Let us recheck it.

wasp898 commented 1 month ago

Can you please add a changelog @lextas? For example https://github.com/bitmovin/bitmovin-player-ui/pull/647/files.

lextas commented 1 month ago

Yes will do, the default PR message said it would be created automatically so I assumed it would. Not sure how to resolve the merge conflict. Do I need to manually up the version? Or is that part automated?

wasp898 commented 1 month ago

Yes will do, the default PR message said it would be created automatically so I assumed it would. Not sure how to resolve the merge conflict. Do I need to manually up the version? Or is that part automated?

Sorry, didn't see your edited message. Release is automatic based on the unreleased changelog entries. Conflict was just because something else was already merged since you opened the PR.