Fix error with number formatting in segment templates

bitmovin / libdash

MPEG-DASH Access Library - Official ISO/IEC MPEG-DASH Reference Implementation

https://bitmovin.com/

589 stars 169 forks source link

Fix error with number formatting in segment templates #13

Open david-welsh opened 7 years ago

david-welsh commented 7 years ago

This fixes what I believe to be an error in the way segment templates are handled if a format tag is provided. According to section 5.3.9.4.4 of ISO/IEC 23009-1:2014, the format tag from the MPD should already have a 'd' character at the end, but the current implementation appends another giving an incorrect URL for that segment.

schellkenig commented 7 years ago

Could you provide a link to an MPD that fails with the current implementation?

david-welsh commented 7 years ago

http://rdmedia.bbc.co.uk/dash/ondemand/bbb/2/client_manifest-common_init.mpd

rockdaboot commented 7 years ago

@schellkenig Is this project still maintained ?

CLAassistant commented 4 years ago

All committers have signed the CLA.