search

bitnami-labs / sealed-secrets

A Kubernetes controller and tool for one-way encrypted Secrets
Apache License 2.0
7.73k stars 687 forks source link

Vendoring fails on 0.26.1 #1492

Closed johanneskastl closed 8 months ago

johanneskastl commented 8 months ago

Describe the bug I have been packaging kubeseal for openSUSE for quite a while. Since 0.26.1 the vendoring fails. As the builds happen without direct internet connectivity, this means I can no longer build a package...

Vendoring is running on my local machine with openSUSE Tumbleweed and go1.22.1

To Reproduce

  1. Checkout the repository
  2. run go mod download
  3. run go mod vendor
  4. See error
ERROR:obs-service-go_modules:go: github.com/bitnami-labs/sealed-secrets imports
        k8s.io/code-generator imports
        k8s.io/code-generator/cmd/openapi-gen imports
        k8s.io/kube-openapi/pkg/generators imports
        k8s.io/gengo/v2: missing go.sum entry for module providing package k8s.io/gengo/v2 (imported by k8s.io/kube-openapi/pkg/generators); to add:
        go get k8s.io/kube-openapi/pkg/generators@v0.0.0-20240228011516-70dd3763d340
go: github.com/bitnami-labs/sealed-secrets imports
        k8s.io/code-generator imports
        k8s.io/code-generator/cmd/openapi-gen imports
        k8s.io/kube-openapi/pkg/generators imports
        k8s.io/gengo/v2/generator: missing go.sum entry for module providing package k8s.io/gengo/v2/generator (imported by k8s.io/kube-openapi/pkg/generators); to add:
        go get k8s.io/kube-openapi/pkg/generators@v0.0.0-20240228011516-70dd3763d340
go: github.com/bitnami-labs/sealed-secrets imports
        k8s.io/code-generator imports
        k8s.io/code-generator/cmd/openapi-gen imports
        k8s.io/kube-openapi/pkg/generators imports
        k8s.io/gengo/v2/namer: missing go.sum entry for module providing package k8s.io/gengo/v2/namer (imported by k8s.io/kube-openapi/pkg/generators); to add:
        go get k8s.io/kube-openapi/pkg/generators@v0.0.0-20240228011516-70dd3763d340
go: github.com/bitnami-labs/sealed-secrets imports
        k8s.io/code-generator imports
        k8s.io/code-generator/cmd/openapi-gen imports
        k8s.io/kube-openapi/pkg/generators imports
        k8s.io/gengo/v2/types: missing go.sum entry for module providing package k8s.io/gengo/v2/types (imported by k8s.io/kube-openapi/pkg/generators); to add:
        go get k8s.io/kube-openapi/pkg/generators@v0.0.0-20240228011516-70dd3763d340
go: github.com/bitnami-labs/sealed-secrets imports
        k8s.io/code-generator imports
        k8s.io/code-generator/cmd/applyconfiguration-gen imports
        k8s.io/code-generator/cmd/applyconfiguration-gen/generators imports
        k8s.io/gengo/generator imports
        golang.org/x/tools/imports: missing go.sum entry for module providing package golang.org/x/tools/imports (imported by k8s.io/gengo/generator); to add:
        go get k8s.io/gengo/generator@v0.0.0-20230829151522-9cce18d56c01
go: github.com/bitnami-labs/sealed-secrets/integration tested by
        github.com/bitnami-labs/sealed-secrets/integration.test imports
        github.com/onsi/ginkgo/v2 imports
        github.com/onsi/ginkgo/v2/ginkgo imports
        github.com/onsi/ginkgo/v2/ginkgo/labels imports
        golang.org/x/tools/go/ast/inspector: missing go.sum entry for module providing package golang.org/x/tools/go/ast/inspector (imported by github.com/onsi/ginkgo/v2/ginkgo/labels); to add:
        go get github.com/onsi/ginkgo/v2/ginkgo/labels@v2.16.0
go: github.com/bitnami-labs/sealed-secrets/integration tested by
        github.com/bitnami-labs/sealed-secrets/integration.test imports
        github.com/onsi/ginkgo/v2 imports
        github.com/onsi/ginkgo/v2/ginkgo imports
        github.com/onsi/ginkgo/v2/ginkgo/build imports
        github.com/onsi/ginkgo/v2/ginkgo/internal imports
        golang.org/x/tools/cover: missing go.sum entry for module providing package golang.org/x/tools/cover (imported by github.com/onsi/ginkgo/v2/ginkgo/internal); to add:
        go get github.com/onsi/ginkgo/v2/ginkgo/internal@v2.16.0
ERROR:obs-service-go_modules:go mod vendor failed

Expected behavior Vendoring should work like before.

alemorcuq commented 8 months ago

Yes, @johanneskastl. This was our fault. It's already fixed in main and next release (expected mid-April) won't have this issue.

We will add a CI step to ensure this doesn't happen again.

Sorry for the inconvenience.