bitnami-labs / sealed-secrets

A Kubernetes controller and tool for one-way encrypted Secrets
Apache License 2.0
7.73k stars 687 forks source link

Label "app.kubernetes.io/instance" in the condition_info Prometheus metric #1579

Closed tewfik-ghariani closed 4 weeks ago

tewfik-ghariani commented 3 months ago

Description of the change

A new label called ss_app_kubernetes_io_instance is added to the sealed_secrets_controller_condition_info Prometheus metric

This label shows the app.kubernetes.io/instance label value of the SealedSecret resource itself, if it exists

e.g

apiVersion: bitnami.com/v1alpha1
kind: SealedSecret
metadata:
  labels:
    app.kubernetes.io/instance: grafana-qa

Here is an example of the newly added metric label: Screenshot 2024-08-14 at 15 53 43

I checked the /metrics endpoint and the metric label is considered empty if it did not exist, thus it is not breaking anything

Benefits

The scraped information of the Sealed Secret resources include an indicator of the instance name / release name associated to that specific resource

Users relying on Grafana may conduct more complex queries to join and map the instance name with other queries

Possible drawbacks

None

Applicable issues

None

Additional information The usage of the app.kubernetes.io/instance label is the standard as it is part of the k8s recommended labels: https://kubernetes.io/docs/concepts/overview/working-with-objects/common-labels/

tewfik-ghariani commented 2 months ago

Hi, is it possible to review this PR? cc @agarcia-oss ^^

github-actions[bot] commented 2 months ago

This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution.

tewfik-ghariani commented 2 months ago

not stale

github-actions[bot] commented 1 month ago

This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution.

github-actions[bot] commented 4 weeks ago

Due to the lack of activity in the last 7 days since it was marked as "stale", we proceed to close this Pull Request. Do not hesitate to reopen it later if necessary.

tewfik-ghariani commented 4 weeks ago

Re-open?