Closed tewfik-ghariani closed 4 weeks ago
Hi, is it possible to review this PR? cc @agarcia-oss ^^
This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution.
not stale
This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution.
Due to the lack of activity in the last 7 days since it was marked as "stale", we proceed to close this Pull Request. Do not hesitate to reopen it later if necessary.
Re-open?
Description of the change
A new label called
ss_app_kubernetes_io_instance
is added to the sealed_secrets_controller_condition_info Prometheus metricThis label shows the
app.kubernetes.io/instance
label value of the SealedSecret resource itself, if it existse.g
Here is an example of the newly added metric label:
I checked the
/metrics
endpoint and the metric label is considered empty if it did not exist, thus it is not breaking anythingBenefits
The scraped information of the Sealed Secret resources include an indicator of the instance name / release name associated to that specific resource
Users relying on Grafana may conduct more complex queries to join and map the instance name with other queries
Possible drawbacks
None
Applicable issues
None
Additional information The usage of the
app.kubernetes.io/instance
label is the standard as it is part of the k8s recommended labels: https://kubernetes.io/docs/concepts/overview/working-with-objects/common-labels/