search

bitnami-labs / sealed-secrets

A Kubernetes controller and tool for one-way encrypted Secrets
Apache License 2.0
7.72k stars 685 forks source link

Metrics serviceName can exceed 63 naming limit #1590

Open guntiskarulis opened 2 months ago

guntiskarulis commented 2 months ago

Which component: Controller: 0.24.5 Helm chart: 2.14.1

Describe the bug Metrics service name can exceed 63 character limit, because Helm template engine will include sealed-secrets.fullname to generate name and in this helper function it will truncates string to 63 characters, hoverver service name itself will add additional characters to the service name, i.e -metrics thus deployments will fail.

Using nameOverride and fullNameOverride will update selector labels, thus breaking controller deployment.

To Reproduce Deploy sealed-secrets chart, with Release.Name close to 63 characters.

Expected behavior Provide a way using Helm values to override metrics service name.

Version of Kubernetes:

Client Version: v1.30.3
Server Version: v1.30.3
alemorcuq commented 1 month ago

To me it sounds natural to truncate the fullname to something like 50 characters to make room for suffixes. What do you think?