bitnami / bncert

Bitnami HTTPS Configuration Tool
https://bitnami.com
Apache License 2.0
5 stars 1 forks source link

Cronjob fails to update certificate if there is an update to bncert #5

Closed CMeldgaard closed 1 year ago

CMeldgaard commented 1 year ago

What steps will reproduce the bug?

When the cronjob that bncert creates runs an update of a certificate it will fail if there is an update to the bncert tool.

Is there some command we can run along with the cronjob, that only updates the bncert tool, but doesn't run an update of the certificates?

What is the expected behavior?

No response

What do you see instead?

-

Additional information

No response

marcosbc commented 1 year ago

Hi @CMeldgaard, AFAIK bncert does not execute with the cron job that gets created by the tool. Here can you see the related logic: https://github.com/bitnami/bncert/blob/main/project/bncert-letsencrypt-functions.xml#L305

CMeldgaard commented 1 year ago

@marcosbc What happens when i run bncert and there is a update ? Does it just run a update of lego ?

marcosbc commented 1 year ago

If you run a complete execution of Bncert (to create a new cert or renew an existing one) up to the final "Success" page, it will upgrade Lego if the installation's one is outdated, as well as replace the cron line with a different randomized timestamp.

But as far as the cron job goes, Bncert is not executed here and therefore nothing will be upgraded: Only the Lego tool is called.

marcosbc commented 1 year ago

Since there haven't been any updates to this issue for a few weeks, I'm proceeding to close it.