search

bitnami / charts-syncer

Tool for synchronizing Helm Chart repositories.
https://bitnami.com
Apache License 2.0
174 stars 31 forks source link

Readme files not updated if relok8s backend used #137

Open migmartri opened 2 years ago

migmartri commented 2 years ago

If the relocation is performed using relok8s, the readme file change is not performed. Maybe this step should be decoupled from the relocation backend used.

I am considering this a regression since in the project documentation we state that readme file changes will be performed.

cc/ @tompizmor @jotadrilo

jotadrilo commented 2 years ago

How could we run this process in the air-gapped scenario?

migmartri commented 2 years ago

It's tricky, some additional metadata will be required to be translated next to the relok8s local bundles. This piece of metadata will contain the repoName that will be used in the readme rewrites. Would that make sense?

jotadrilo commented 2 years ago

I would have to take a look at the big picture first. Can you describe which is the charts-syncer -> relok8s behavior? What is modifying the values.yaml files and so on in that case? It feels like the README.md is out of the scope of relok8s but maybe there is no other place to perform additional pre-processing before packaging the charts again.