search

bitnami / charts-syncer

Tool for synchronizing Helm Chart repositories.
https://bitnami.com
Apache License 2.0
174 stars 31 forks source link

Feature Proposal: Add Flag `--image-patterns` to cmd #165

Open panpan0000 opened 2 years ago

panpan0000 commented 2 years ago

Currently , if we would like to enable relocateContainerImages=true feature to push image to target and modify the image repo in new helm chart, it requires the source helm chart has embeded .relok8s-images.yaml , like mariadb chart in https://charts.app-catalog.vmware.com/.

But unfortunately, NOT all helm charts have this file embeded, even the bitnami helm charts. Maybe only those charts in https://charts.app-catalog.vmware.com will include this file in the world.

The relok8s (https://github.com/vmware-tanzu/asset-relocation-tool-for-kubernetes) has a flag --image-patterns to specific an external .relok8s-images.yaml , which it's more friendly , not making it a hard requirement of source chart.

So design proposal: add --image-patterns :

People can create an external pattern file my-pattern.yaml (external means standalone, out of helm charts)

Usage 

charts-syncer sync --image-patterns  my-pattern.yaml

In this way, every charts can be "relocated", not limited to those in catalog.vmware.com.

panpan0000 commented 2 years ago

Hope this is can be fulfilled and make this open source tool more useful and friendly. then we can have a my-pattern.yaml to cover all helm charts to be synced, instead of modify the helm packages which we cannot control.

HammerNL89 commented 1 year ago

Yes this would be a nice feature, currently I'm forced to use a separate tool for syncing the required images which adds complexity.