Open asafsgit opened 1 year ago
Hi,
I believe that this has to do with breaking changes. If we add commonLabels to the PVCs, then we need to bump the major version because there would be installations using commonLabels that will break after updates. Therefore, I think we were waiting for a major bump to add that section.
Thanks @javsalgar!
Please mind that it is not only commonLabels. This config also doesn't work:
master:
persistence:
labels:
foo: bar
Will wait for your next major release
It seems this is happening with the RabbitMQ chart too. I tried to set commonLabels
and also persistence.labels
, and it didn't take any effect on created PVCs.
Below is what my values.yaml
looks like right now.
Am I doing something wrong?
Hi,
In the RabbitMQ chart the persistence.labels value is being considered
- apiVersion: v1
kind: PersistentVolumeClaim
metadata:
name: data
{{- $claimLabels := include "common.tplvalues.merge" ( dict "values" ( list .Values.persistence.labels .Values.commonLabels ) "context" . ) }}
labels: {{- include "common.labels.matchLabels" ( dict "customLabels" $claimLabels "context" $ ) | nindent 10 }}
{{- if .Values.persistence.annotations }}
annotations: {{- include "common.tplvalues.render" ( dict "value" .Values.persistence.annotations "context" $) | nindent 10 }}
{{- end }}
Could you confirm that you are using the latest version of the chart?
Hi @javsalgar. I would say that I'm using the latest version, but yesterday, they released 12.7.0
, which didn't touch things like this.
Below are my releases extract with the command: helm list -n rabbitmq-system
.
[
{
"name": "rabbitmq",
"namespace": "rabbitmq-system",
"revision": "1",
"updated": "2024-01-16 12:19:46.021737506 -0300 -03",
"status": "deployed",
"chart": "rabbitmq-12.6.3",
"app_version": "3.12.12"
},
{
"name": "rabbitmq-cluster-operator",
"namespace": "rabbitmq-system",
"revision": "1",
"updated": "2024-01-15 20:56:20.198847595 -0300 -03",
"status": "deployed",
"chart": "rabbitmq-cluster-operator-3.10.10",
"app_version": "2.6.0"
}
]
Moving it to a new conversation https://github.com/bitnami/charts/issues/22364
Name and Version
bitnami/redis 18.1.6
What architecture are you using?
amd64
What steps will reproduce the bug?
Are you using any custom parameters or values?
No response
What is the expected behavior?
The stateful set should have rendered the common labels for the PVC template:
What do you see instead?
Additional information
seems related to this issue: #20264
If I change in the statefulset template from
to
I can see my label