bitnami / charts

Bitnami Helm Charts
https://bitnami.com
Other
9.01k stars 9.22k forks source link

[bitnami/mastodon] missing support for redis sub-chart's `redis.auth.existingSecret` #20903

Open jessebot opened 12 months ago

jessebot commented 12 months ago

Name and Version

bitnami/mastodon

What architecture are you using?

amd64

What steps will reproduce the bug?

On the latest version of k3s using Argo CD, attempt to deploy the latest mastodon chart using the redis subchart with the below values set.

Are you using any custom parameters or values?

relevant values:

## ref: https://github.com/bitnami/charts/blob/main/bitnami/redis/values.yaml
redis:
  enabled: true
  fullnameOverride: mastodon-redis
  ## Set Redis architecture
  architecture: standalone
  auth:
    ## Name of a secret containing redis credentials
    existingSecret: "mastodon-redis-credentials"
    existingSecretPasswordKey: "redis-pasword"

which I've based on the docs here: https://github.com/bitnami/charts/tree/8c7bc70727aa6096895cf3f3a5d5b55e88470cf1/bitnami/redis#redis-common-configuration-parameters

What is the expected behavior?

This section of the _helpers.tpl below should include checking the following values for existing Secret names and secret key names:

https://github.com/bitnami/charts/blob/8c7bc70727aa6096895cf3f3a5d5b55e88470cf1/bitnami/mastodon/templates/_helpers.tpl#L400-L430

Based on the docs here: https://github.com/bitnami/charts/tree/8c7bc70727aa6096895cf3f3a5d5b55e88470cf1/bitnami/redis#redis-common-configuration-parameters

What do you see instead?

The init-job fails with:

Error: secret "mastodon-redis" not found

Additional information

The values section showing existingSecret for redis: https://github.com/bitnami/charts/blob/8c7bc70727aa6096895cf3f3a5d5b55e88470cf1/bitnami/mastodon/values.yaml#L1357-L1381

which are documented here: https://github.com/bitnami/charts/tree/main/bitnami/mastodon#redis-sub-chart-parameters

jessebot commented 12 months ago

As a work around, I'm just using the externalRedis parameters and setting redis.enabled to false.

carrodher commented 12 months ago

Thank you for bringing this issue to our attention. We appreciate your involvement! If you're interested in contributing a solution, we welcome you to create a pull request. The Bitnami team is excited to review your submission and offer feedback. You can find the contributing guidelines here.

Your contribution will greatly benefit the community. Feel free to reach out if you have any questions or need assistance.

jessebot commented 12 months ago

I'll do my best to get this done in the next couple of weeks, but if I don't, or someone else has the time sooner, please feel free to submit a PR ahead of me :)

github-actions[bot] commented 11 months ago

This Issue has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thanks for the feedback.

jessebot commented 11 months ago

please don't close this