Valkey: Metrics exporter uses wrong environment variables

gtudan commented 6 months ago

Name and Version

bitnami/valkey:0.1.2

What architecture are you using?

amd64

What steps will reproduce the bug?

Install the chart as usual
make sure to enable authentication for Valkey
enable the metrics exporter

Are you using any custom parameters or values?

valkey:
  metrics:
    enabled: true
  auth:
    enabled: true

What is the expected behavior?

Metrics exporter is able to connect to the redis-master

What do you see instead?

Metrics exporter get authentication errors

Additional information

The exporter is still the original redis-exporter. But the configuration properties have been renamed to VALKEY_, especially VALKEY_PASSWORD. They should still be `REDIS_`

The metrics exporter works if I manually set the property:

  metrics:
    enabled: true
    extraEnvVars:
      - name: REDIS_PASSWORD
        valueFrom:
          secretKeyRef:
            name: redis-secret
            key: REDIS

rafariossaa commented 6 months ago

Hi @gtudan , Thanks for spotting this. As you have found the issue and provided a fix for it, would you like to contribute and send a PR ? We will be glad to review and merge it.

mkyc commented 6 months ago

In nevest 0.2.0 version of helm chart that is no longer required. If there is global.valkey.password value set that is enough and VALKEY_PASSWORD is set and is enough.

github-actions[bot] commented 6 months ago

This Issue has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thanks for the feedback.

github-actions[bot] commented 5 months ago

Due to the lack of activity in the last 5 days since it was marked as "stale", we proceed to close this Issue. Do not hesitate to reopen it later if necessary.

bitnami / charts